Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GitHub Enterprise #3

Closed
Plonk42 opened this issue Oct 15, 2024 · 4 comments · Fixed by #4
Closed

Support for GitHub Enterprise #3

Plonk42 opened this issue Oct 15, 2024 · 4 comments · Fixed by #4
Assignees

Comments

@Plonk42
Copy link

Plonk42 commented Oct 15, 2024

Hey, thank you for this action!

I was investigating if this could help us facing actions/toolkit#1264, but I think it wouldn't work in our GitHub Enterprise environment.

In particular, I think the input github-server-url should be use there instead of hard-coded https://api.github.com/ at:

content=$(curl -L -H "Accept: application/vnd.github+json" -H "Authorization: Bearer ${{ inputs.token }}" -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/repos/${{ github.repository }}/actions/runs/${{ github.run_id }})

@dariocurr
Copy link
Owner

dariocurr commented Oct 15, 2024

Great suggestion, thank you!

But I guess the input we should use is github.api_url. Isn't it?

@dariocurr dariocurr self-assigned this Oct 15, 2024
@dariocurr dariocurr linked a pull request Oct 15, 2024 that will close this issue
dariocurr added a commit that referenced this issue Oct 15, 2024
@dariocurr
Copy link
Owner

dariocurr commented Oct 15, 2024

Please ensure that it works also in GitHub Enterprise environments. I have no easy way to test it

@dariocurr dariocurr reopened this Oct 15, 2024
@Plonk42
Copy link
Author

Plonk42 commented Oct 15, 2024

I had to downgrade the checkout action to the latest version supported on my GHE instance (actions/checkout@v4.1.1 instead of actions/checkout@v4.2.1), which also required to remove the ssh-user input, but apart from this it seems to work great. Thanks for the quick fix!

@Plonk42 Plonk42 closed this as completed Oct 15, 2024
@dariocurr
Copy link
Owner

Thank you. I'm glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants