Fix widget state interaction after dispose #193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
After updating to v4.2 from v3.x I have encountered some errors logs in the Sentry dashboard of a production app coming from the package. Here are some examples:
All three seem to indicate that the widget is doing setState or similar after it has been disposed, so I've included an is mounted check.
I've also updated the openCloseDial listener disposal by pointing to the same function. I that the following doesn't work
widget.openCloseDial?.removeListener(() {});
It would simply remove a listener that has never been saved in the first place.