-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide childAnimation as param #247
provide childAnimation as param #247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can you rebase it, it has conflicts. |
Sure. would do that |
@prateekmedia done. Also, if possible, please test it. I have tested it but still. |
@AbhishekDoshi26 I am quite busy these days and the new maintainer is @luca-colazzo. |
Yep. Tested. Working properly. |
Will test when home |
_MyHomePageState is a SingleTickerProviderStateMixin but multiple tickers were created. This was triggered when clicking on anything
Just passing the animation Curve is sufficient, more efficient and just work
Also increased duration to see the actual animation
This PR solves issue #246 and allows us to pass
childAnimation
as a separate param.