Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added palette management from GUI, reworked settings management with … #9

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from

Conversation

dowmeister
Copy link

  • Added palette management from GUI with hex colors converted to SolidBrush RGB and saved to settings
  • Reworked settings management adding new objects and served with a singleton object
  • Tile generation in async with Task, no UI block anymore
  • Added Status bar strip with label and progress bar managed async with Invoke and Action
  • Added Tile Size and Map Padding setting in Tile Generator settings form
  • All generator form options persisted in settings json

…singleton object and more properties, tile generation in async + label and progress bar, changes to generator form with tile size and map padding set from GUI
@dariowouters
Copy link
Owner

Very nice!
Just two things:
When starting the program and no settings file exists yet, it won't use the default values because it initializes the palette and tileGenerator settings in the Settings constructor, and so they will never be null in the SettingsManager constructor (where the default values get set).

Async tile generation seems to be missing?

@dowmeister
Copy link
Author

oh yes, sorry. it was a bug already discovered and fixed on local version but I have other code edited so didn't committed it (was trying to play with GeoJson).

for the async....mmm.. It should be committed, I will check!

@dowmeister
Copy link
Author

for some reason I've lost the async development... maybe messed up with some guy merge.. I'll rewrite it :)

Francesco and others added 3 commits November 12, 2019 22:17
…er interact with map (not all code thread-safe?)

Default map palette fix when no settings are available
Added Mods to Settings to be persisted (but not managed)
@dowmeister
Copy link
Author

Hi, any update on meeting this pr?

dowmeister and others added 2 commits April 9, 2020 12:30
…singleton object and more properties, tile generation in async + label and progress bar, changes to generator form with tile size and map padding set from GUI
…er interact with map (not all code thread-safe?)

Default map palette fix when no settings are available
Added Mods to Settings to be persisted (but not managed)
@dowmeister
Copy link
Author

Hi,
i've continued to work on my fork and after the last changes you did on develop branch i've merged again solving all confilcts:

What i've got so far:

  • Maintained my implementation of SettingsManager persisting to the disk and available in the whole app as a Singleton
  • Map Palette settings saving
  • Added Bus Stops saving with specific settings
  • Added City boundaries detection to Overlays export
  • Added specific button to export only map data without generating the tiles

Can you consider to merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants