Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible concurrency issue #5

Closed
artem-zinnatullin opened this issue Mar 29, 2016 · 2 comments
Closed

Possible concurrency issue #5

artem-zinnatullin opened this issue Mar 29, 2016 · 2 comments
Assignees
@uKL
Labels
bug Bug that is caused by the library

Comments

@artem-zinnatullin
Copy link

Yo guys, was just looking into sources and found pretty suspicious usage of non-thread-safe collection.

Please consider using ConcurrentHashMap there because it may be accessed from different threads with subscribeOn and unsubscribeOn.

Library looks nice! (extra points for Spock!)
@uKL
Copy link
Collaborator

uKL commented Mar 30, 2016

Yes, this may be true, we will take a look. However ConcurrentHashMap may not be enough. We should synchronize whole read/create operation.

@uKL
Copy link
Collaborator

uKL commented Mar 30, 2016

Issue will be fixed by #6.

uKL added a commit that referenced this issue Mar 30, 2016
@uKL
Merge pull request #6 from Polidea/bugfix/issue-5
dd5dab0 
Fixed concurrency issues with submitting scan requests. #5
@uKL uKL self-assigned this Mar 30, 2016
@uKL uKL added this to the 1.0.1 milestone Mar 30, 2016
@uKL uKL added the bug Bug that is caused by the library label Mar 30, 2016
@uKL uKL closed this as completed Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uKL uKL

Labels
bug Bug that is caused by the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artem-zinnatullin @uKL