Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat add uniswapv2_simulate benchmark #183

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Feat add uniswapv2_simulate benchmark #183

merged 4 commits into from
Jul 22, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jul 1, 2024

Add benchmark for uniswapv2_simulate function

0xKitsune
0xKitsune reviewed Jul 5, 2024
View reviewed changes
benches/uniswapv2_simulate.rs Outdated Show resolved Hide resolved
benches/uniswapv2_simulate.rs Outdated Show resolved Hide resolved
@0xKitsune
Copy link
Collaborator

Thanks for opening this PR. I left a few minor comments. Once these are fixed, we can merge this in.

@ghost
Copy link
Author

ghost commented Jul 6, 2024 •
edited by ghost
Loading

I updated the input, I believe we keep the state to be static instead of random to make sure when tuning, we have consistent benchmark results.

@ghost ghost force-pushed the feat_add_uniswapv2_simulate_benchmark branch from 2a75c48 to d6ad931 Compare July 7, 2024 20:44
@0xKitsune 0xKitsune merged commit 3ec419b into darkforestry:main Jul 22, 2024
0 of 2 checks passed
@ghost ghost deleted the feat_add_uniswapv2_simulate_benchmark branch July 26, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xKitsune