Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid links when served with trailing slash #212

Merged
merged 1 commit into from
Oct 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/contributing/general-concepts.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ type pattern =
```

These definitions are in ReScript (we have a
[guide to ReScript for Dark developers](ocaml-for-dark-developers)). Briefly,
[guide to ReScript for Dark developers](ocaml-for-dark-developers.md)). Briefly,
this means that an `expr` is an integer (which is made up of an id and a string)
or a bool (made up of an id and a string), or a `match` (which is an id, an
expression to match on, and a list of patterns and expressions), etc
Expand Down
4 changes: 2 additions & 2 deletions docs/contributing/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ title: Getting started
---

_Note that you can also
[contribute without writing OCaml code](./if-you-dont-know-ocaml)!_
[contribute without writing OCaml code](if-you-dont-know-ocaml.md)!_

This guide will get you making your first PR to the Dark repo. It helps you set
up the repo, write your first test, and make your first pull request. After
that, it will guide you on how to work on bigger things, especially the current
big project to [port the backend to F#](porting-the-dark-backend).
big project to [port the backend to F#](porting-the-dark-backend.md).

If you'd like help contributing, you can
[book a pairing session with Paul Biggar to help](https://calendly.com/paul-biggar/dark-contributor-pairing-session).
Expand Down
2 changes: 1 addition & 1 deletion docs/contributing/if-you-dont-know-ocaml.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ Dark. Fortunately, they are very similar to Dark.

There are a number of resources to help as well:

- [A guided walkthrough of making your first PR](/contributing/adding-your-first-test)
- [A guided walkthrough of making your first PR](adding-your-first-test.md)
- [good first bugs](https://github.com/darklang/dark/issues?q=is%3Aopen+is%3Aissue+label%3Agood-first-bug)
assume you don't know anything about F# or ReScript

Expand Down
2 changes: 1 addition & 1 deletion docs/contributing/making-your-first-pull-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ request:
> any tests so I added one."

While this doesn't follow our
[Pull Request guidelines](/contributing/making-a-pull-request#writing-a-successful-pull-request-message),
[Pull Request guidelines](making-a-pull-request.md#writing-a-successful-pull-request-message),
it's fine for a first contribution (and you can ignore the PR template too for
now).

Expand Down
6 changes: 3 additions & 3 deletions docs/contributing/next-contribution.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@
title: Your next contribution
---

We have everyone start with [a first PR](getting-started), which makes a small
We have everyone start with [a first PR](getting-started.md), which makes a small
but valuable contribution. Now that you've got it done, you can build something
(a little bit) bigger.

## Porting backend to F#

One of the most valuable projects right now is porting OCaml code to F# in the
backend. See [Porting the Dark backend](porting-the-dark-backend).
backend. See [Porting the Dark backend](porting-the-dark-backend.md).

## Getting started

Below you'll find resources to help you figure out what to work on. After that,
head over to [Working in the Dark repo](ocaml-for-dark-developers) to learn how
head over to [Working in the Dark repo](ocaml-for-dark-developers.md) to learn how
to contribute bigger things, like the basics of F#/ReScript, the layout of the
repo, technical guides to different parts of the codebase and product, and
product and vision docs about where Dark is going.
Expand Down