Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test rewrite improvements #2

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Test rewrite improvements #2

merged 2 commits into from
Nov 11, 2021

Commits on Nov 9, 2021

  1. Reduce higher-order function in test template 

    This is just a cosmetic thing -- there's no need for the higher-order
func used to create mini test suites, given the protocol and git
implementation. This made the Gingko version clearer, arguably, but it
can be reduced away here for a bit less nesting.

Signed-off-by: Michael Bridgen <michael@weave.works>
    @squaremo
    squaremo committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    6400e10 View commit details
    Browse the repository at this point in the history

  2. Collect test args into struct 

    This tidies the random string testWithRepoAndImagePolicy() arguments
into a struct, which reduces clutter (and the chance of getting them
in the wrong order) in invocations.

Signed-off-by: Michael Bridgen <michael@weave.works>
    @squaremo
    squaremo committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    024fbf5 View commit details
    Browse the repository at this point in the history