-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set/unset alarms (configurable) #29
Conversation
I considered this feature last year, but couldn't get it to work in Google Calendar for some reason so chucked it in the bin. I could certainly use it myself though. Only comment I have on this PR is do you think we could find a nicer way to express the triggers? I know those are the iCal values, but something more user readable that we can compile would be great. |
Hmm... good point. I just saw in the rfc document that also absolute datetime can be defined, so quite flexible. But having a fixed date in our use case attached to all events probably won't make sense. So simplest solution would be to add link to documentation about format and to check the format by parsing it into time in order to check if it is technically valid entry |
Or we just support i.e. "\d+ days" and "\d+ hours" simply.... |
Implemented something, please have a look @darkphnx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a solid approach. A little refactoring to tidy up would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, just onto the nitpicks now, and then some tests.
So then only tests open so far |
Added tests, you can also have a look here @darkphnx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
Hi @darkphnx
I have one more feature I need.
As said I want to split with this project one calendar into multiple logical.
There I also need different alarms (as they will be imported to another tool which handles them).
As alarms are something total different than filters, I added a dedicated section.
Not sure if this feature is already going too far for an "ical-filter-proxy".