Skip to content

New Physicochemical Features

Ian Pendleton edited this page May 26, 2020 · 1 revision

Ongoing Physicochemical Feature Discussion

Please review this documentation before trying to add new physicochemical features (feats*).

New physicochemical features should be added to the ongoing type_command.csv table on report and through calc_command.py. User level modifications to these files are described in the user documentation.

The instructions for new features and ongoing development are summarized here:

New Feature Dev Checklist

  • Pick a feature
  • Ensure we don't have it already. (See dataset description and type_command.csv)
  • Create an issue in ESCLATE_report (or associated code base)
  • Update “Ongoing Development” list

Development

  • Add feature to the type_command.csv table in escalate
  • Verify that the command generates the expected results before requesting merge!

Once Complete

  • Merge request on GIT wait for approval (NEVER MERGE ALONE)
  • Move issue from “Ongoing development” to “Completed Development Log”

Try a search on this wiki!

Clone this wiki locally