Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discarding history does not remove darktable|style tags from image #17310

Closed
ralfbrown opened this issue Aug 12, 2024 · 0 comments
Closed

discarding history does not remove darktable|style tags from image #17310

ralfbrown opened this issue Aug 12, 2024 · 0 comments
Assignees
Labels
bug: pending someone needs to start working on that priority: high core features are broken and not usable at all, software crashes release notes: pending scope: DAM managing files, collections, archiving, metadata, etc.
Milestone

Comments

@ralfbrown
Copy link
Collaborator

Describe the bug

The code for dt_history_delete_on_image_ext in src/common/history.c intends to remove all style tags from the image, but fails to do so because it passes a string with a wildcard to a function which only does an exact match (and could only handle a single match even if it supported wildcards).

Steps to reproduce

  1. apply one or more styles to an image
  2. have both the history stack and tagging modules open
  3. enable display of darktable tags in the tagging module
  4. select the image, then use discard history
  5. hover over the image and note that the style tag(s) are still displayed in the tagging module

Expected behavior

the style tags should be removed since they no longer apply to the image

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

self compiled

darktable version

master

What OS are you using?

Linux

What is the version of your OS?

Mageia 9

Describe your system?

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

@TurboGit TurboGit added this to the 5.0 milestone Aug 12, 2024
@TurboGit TurboGit added priority: high core features are broken and not usable at all, software crashes scope: DAM managing files, collections, archiving, metadata, etc. bug: pending someone needs to start working on that release notes: pending labels Aug 12, 2024
@TurboGit TurboGit self-assigned this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: pending someone needs to start working on that priority: high core features are broken and not usable at all, software crashes release notes: pending scope: DAM managing files, collections, archiving, metadata, etc.
Projects
None yet
Development

No branches or pull requests

2 participants