-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
po/colorpicker edit - edit area & point #17051
base: master
Are you sure you want to change the base?
Conversation
Yes, indeed a step into a better workflow. One usability downside, you have to prior-select the picker with the correct "mode" (either click for point or right-click for area) and thus have to know the live samples mode. Could we instead activate the main picker in the correct way via right-click on the live sample? |
Sure, that's what I commented in my first post :) |
Ahh, didn't get that. So show me the way to the next ... :-) |
No time for 4.8.1 and actually not a fix so moving this for 5.0. |
we need to select it select the shape in it ctrl+click over an area and when this is done the picker MUST be active change size / position click back on the picker (= deselect it) the area should properly be recorded.
deb3371
to
7e0c2e1
Compare
@TurboGit let me know if you want a review / test! |
Fact is that this is still buggy IIRC. I need to resume work on it when I'll have time. |
Allow for editing area & point as hinted by the tooltip.
@jenshannoschwalm : This is based on top of your PR but it independent, can you test?
How it works:
I'd like to avoid 1 and as soon as we right click we enter in edit mode and maybe right-click again to update the sample. Seems a better user interaction to me, what do you think?