Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

po/colorpicker edit - edit area & point #17051

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

TurboGit
Copy link
Member

Allow for editing area & point as hinted by the tooltip.

@jenshannoschwalm : This is based on top of your PR but it independent, can you test?

How it works:

  1. click on picker icon
  2. right click on a sample
  3. move it / change size of area
  4. deselect the picker

I'd like to avoid 1 and as soon as we right click we enter in edit mode and maybe right-click again to update the sample. Seems a better user interaction to me, what do you think?

@TurboGit TurboGit added this to the 4.8.1 milestone Jun 24, 2024
@TurboGit TurboGit self-assigned this Jun 24, 2024
@TurboGit TurboGit added bugfix pull request fixing a bug feature: enhancement current features to improve labels Jun 24, 2024
@jenshannoschwalm
Copy link
Collaborator

Yes, indeed a step into a better workflow.

One usability downside, you have to prior-select the picker with the correct "mode" (either click for point or right-click for area) and thus have to know the live samples mode. Could we instead activate the main picker in the correct way via right-click on the live sample?

@TurboGit
Copy link
Member Author

TurboGit commented Jun 24, 2024

Could we instead activate the main picker in the correct way via right-click on the live sample?

Sure, that's what I commented in my first post :)

@jenshannoschwalm
Copy link
Collaborator

Ahh, didn't get that. So show me the way to the next ... :-)

@TurboGit
Copy link
Member Author

No time for 4.8.1 and actually not a fix so moving this for 5.0.

@TurboGit TurboGit modified the milestones: 4.8.1, 5.0 Jul 16, 2024
we need to select it
select the shape in it ctrl+click over an area
and when this is done the picker MUST be active
change size / position
click back on the picker (= deselect it)

the area should properly be recorded.
@jenshannoschwalm
Copy link
Collaborator

@TurboGit let me know if you want a review / test!

@TurboGit
Copy link
Member Author

@TurboGit let me know if you want a review / test!

Fact is that this is still buggy IIRC. I need to resume work on it when I'll have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug feature: enhancement current features to improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants