Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overlay conversions #17102

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix overlay conversions #17102

wants to merge 1 commit into from

Conversation

jenshannoschwalm
Copy link
Collaborator

@jenshannoschwalm jenshannoschwalm commented Jul 7, 2024 •
edited
Loading

We don't want to do any colorspace conversion in the overlayed image.

Thus we

  • include colorin module in the "module filter out" list
  • we don't enforce colorin via it's commit_params if we develop with finalscale enabled.

See #17060

@TurboGit not completely sure about this yet thus WIP.

@jenshannoschwalm jenshannoschwalm added bugfix pull request fixing a bug priority: medium core features are degraded in a way that is still mostly usable, software stutters scope: image processing correcting pixels scope: color management ensuring consistency of colour adaptation through display/output profiles labels Jul 7, 2024
@jenshannoschwalm jenshannoschwalm marked this pull request as draft July 7, 2024 10:48
@jenshannoschwalm
Fix overlay conversions
d408bd5 
We don't want to do any colorspace conversion in the overlayed image.

Thus we
- include colorin module in the "module filter out" list
- we don't enforce colorin via it's commit_params if we develop with finalscale enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix pull request fixing a bug priority: medium core features are degraded in a way that is still mostly usable, software stutters scope: color management ensuring consistency of colour adaptation through display/output profiles scope: image processing correcting pixels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jenshannoschwalm