Enable the metadata editor in darkroom view #17263
Conversation
|
I'm not sure we are going in the right direction. We already have Add a tick in utility modules (listed above) preferences dialog to select whether it must be shown in darkroom or not. So we let the user the full control of whether a module should be in darkroom. |
|
OOps, don't know how the change from |
no problem, it's reversible :) |
@victoryforce: Are you currently working on this? If not, I would like to take over. |
Thank you, Mario, for offering to help! I, however, actually worked on it, and now I'm finalizing the code, testing it and thinking about the text of the comment-rationale for why I did it in a slightly different way than suggested (not inside the module's local preferences). I hope to force-push the updated code tomorrow (today we had 2 hours of electricity after 7 hours of absence, so there was little opportunity to work). |
|
https://github.com/dterrahe/darktable/commits/ancil/ |
|
Another proposal from me: Put everything in the darkroom section of the preferences panel. https://github.com/zisoft/darktable/commits/darkroom-modules/
|
No please, we have worked hard to remove entries from the main preferences to avoid having too much entries. So, better having the selection into the module's preference dialog. |
I will try to summarize possible interface solutions and their inherent drawbacks. An excessive number of settings in the program's global settings dialog psychologically discourages the user, he feels overwhelmed and tends to consider the program difficult. And it does not depend on how difficult the program is to use. People just don't like having to choose. In practice, we need to find a balance between the demands of advanced users to have certain options and the desire of the majority not to see many options in front of them (which will have to be read, understood and thought about which choice to make). In part, the problem is solved by intelligent structuring of the settings, which slightly reduces the mental load on the user. It is important that darktable, unlike many other programs, has a convenient and understandable interface for certain settings of a specific module - this is the "local menu of the module", a hamburger in the header of the module. This menu is typically used to create and select module presets, but may also contain other menu items. In some cases, through this menu, you can open a dialog for setting options specific to the module. Having these local preferences makes it possible to offload the global settings from everything that only applies to one particular module. I first tried adding the module darkroom visibility option to the local preferences dialog as suggested by @TurboGit. Or rather, I just made a quick mockup and started to see how it looks. Unfortunately, such a solution also does not look optimal. The setting of whether the module is visible in darkroom mode looks alien among the actual module settings. Because this, in fact, is not a setting of the module itself, it does not determine the behavior of the module itself. In the preferences interface of the export module, for example, adding such a parameter looks extremely artificial and alien. The group in the darkroom section of the global settings looks at least logical, although we want to avoid such a solution. In addition, moving module visibility toggle to any settings dialog does not have the highest discoverability, because some users have a habit of not opening any settings, working only with what they see in front of them. In fact, the ideal place for this toggle is a menu item in the module's local menu itself, without pushing it inside the module's "preferences...". In a similar way, "show guides" are implemented in the processing modules. This is what I will propose in the next PR. I am closing this PR so as not to mix the discussion of the first simple solution (adding visibility for a specific module) and the new one, which adds general support for the toggle in the utility modules menu. |
Resolves #17261.