Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R5 Mark II noiseprofile #17347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

piratenpanda
Copy link
Contributor

Done like the one for the R5, works well on my samples but maybe @rawfiner wants to take a look at it. The x2 rule for the second a value doesn't seem to be given. The script was not complaining though.

noise_result.pdf

@kmilos
Copy link
Contributor

kmilos commented Aug 20, 2024

We will have might want to wait for LibRaw support (and #17376) to merge this.

@TurboGit TurboGit added scope: noise profile adding noise profiles for new cameras depends: libraw for libraw related issues labels Aug 20, 2024
@TurboGit TurboGit added this to the 5.0 milestone Aug 20, 2024
@piratenpanda
Copy link
Contributor Author

sure, wanted to submit the PR to have it "off the list" :)

@cytrinox
Copy link
Contributor

@kmilos why is there a dependency on libraw for noise profiles? The noise profile is also useful for (converted) DNG files and a new libraw release may take ~2 years.

@kmilos
Copy link
Contributor

kmilos commented Aug 20, 2024

We ideally want to have base support implemented first, if not for the model string normalisation: "Canon EOS R5m2" to "EOS R5 Mark II". Without it, the automatic profile lookup won't work, and it'll be available to choose manually only (which is of course an option should people prefer to have it before LibRaw makes it public).

@victoryforce
Copy link
Collaborator

which is of course an option should people prefer to have it before LibRaw makes it public

The quasi-support of the camera through Adobe DNG Converter is also not ideal, but it is better than not being able to work with images in darktable. Therefore, I see this option as desirable. This will improve the user experience (ok, not in an ideal way) for those who want to work with these images without waiting for libraw support.

@piratenpanda
Copy link
Contributor Author

piratenpanda commented Aug 22, 2024

People who don't want to wait for libraw can follow my findings here and compile R5m2 support themselves https://discuss.pixls.us/t/how-to-add-camera-support-to-libraw-darktable/44774

finetuned wbpresets can't be created yet, because the script does not create any output. Guess it needs exiftool to support the tags.

@kmilos kmilos added depends: libraw for libraw related issues and removed depends: libraw for libraw related issues labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends: libraw for libraw related issues scope: noise profile adding noise profiles for new cameras
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants