improve handling of unsupported images #17367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The skull image should be reserved for missing or otherwise inaccessible files (e.g. no read permission). This will let the user distinguish between the cases - not available - unsupported file type (e.g. HEIF when libheif not linked) or subformat (e.g. compression) - read error or corrupted file
Instead of retrying an image load which results in an error FOUR HUNDRED times, only do a few retries with pauses in between (the latter just so that the user gets a chance to read the error message).
To properly tell the user what happened, rawspeed needs at least a new exception type for unsupported cameras and preferably also one for unsupported features like compression mode. Currently, both of those are thrown as "decode error", which signals a corrupted file in cases other than those two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more internal failure codes and make error messages to the user more specific based on those additional codes. Also suppress the "failed to read whitebalance" error when an image could not be fully loaded (e.g. due to unsupported camera model).
There are now three different icons for images which can't be edited by the user - the skull for missing/unreadable image files, a warning triangle for corrupted files or when an I/O error occurred, and a question mark for unsupported files (camera model, compression mode, etc.). As you can tell from the icons, I'm not an artist, so improved renditions are not just welcome, they are requested.
Right now, the question mark will never show for two reasons - rawspeed uses the exact same exception type for both unsupported and corrupt files, and imageio_open() blindly tries every possible loader until one succeeds, so a later loader will replace the error code from the loader which could actually handle the file type with its own error.
A PR to address the second of these is coming.