Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused introspection comment on the variable #17370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

victoryforce
Copy link
Collaborator

This PR removes the unused introspection comment on the variable, because it is used as a regular variable, and not in functions that work with the introspection system (*_from_params). Functionally, it will not bring noticeable benefit (at most, throwing out an unnecessary string from the POT file). It is more about improving the quality, correctness and readability of the source code.

@ralfbrown ralfbrown added the scope: codebase making darktable source code easier to manage label Aug 25, 2024
@jenshannoschwalm
Copy link
Collaborator

Hmm, i wouldn't say this is good. We certainly would want correct introspection information possibly for every parameter that gets committed - sure we are missing many still.

This would allow testing for buggy parameters inserted 'somehow' for example by incorrect presets. We had such problems.

@TurboGit
Copy link
Member

I agree with @jenshannoschwalm !

@dterrahe
Copy link
Member

functions that work with the introspection system (*_from_params).

Introspection is also used to initialise default_params (in dt_iop_default_init) and to show the tooltip with changes in the history module (_lib_history_change_text). This PR removes the default/changes it to zero. This would impact new images/module instances and when pressing module reset. Which would not be visible to the user, except in the history module. $DESCRIPTION is a user visible translatable string and should ideally not contain shortened words or underscores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: codebase making darktable source code easier to manage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants