Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native_powr() in costly _calc_refavg() #17374

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

jenshannoschwalm
Copy link
Collaborator

As b in native_powr(a,b) is always in safe range here we can use the native variant for a significant performance gain.

As b in native_powr(a,b) is always in safe range here we can use the native variant
for a significant performance gain.
@jenshannoschwalm jenshannoschwalm added scope: performance doing everything the same but faster OpenCL Related to darktable OpenCL code labels Aug 26, 2024
@jenshannoschwalm jenshannoschwalm added this to the 5.0 milestone Aug 26, 2024
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit b70b25e into darktable-org:master Aug 26, 2024
6 checks passed
@ralfbrown
Copy link
Collaborator

How does native_powr(x,3.0f) compare to just doing x * x * x ?

@jenshannoschwalm jenshannoschwalm deleted the opencl_opposed branch August 26, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenCL Related to darktable OpenCL code scope: performance doing everything the same but faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants