Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crop for square raw files #17379

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jenshannoschwalm
Copy link
Collaborator

When fixing the dimensions for the chosen aspect we have to assume a landscape or not. This check failed so far, now we assume a square to be a landscape too at all code parts.

Fixes #17366 (the "real bug" part)

When fixing the dimensions for the chosen aspect we have to assume a landscape or not.
This check failed so far, now we assume a square to be a landscape too at all code parts.
@jenshannoschwalm jenshannoschwalm added this to the 5.0 milestone Aug 26, 2024
@jenshannoschwalm jenshannoschwalm added the bugfix pull request fixing a bug label Aug 26, 2024
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 80f8355 into darktable-org:master Aug 27, 2024
6 checks passed
@jenshannoschwalm jenshannoschwalm deleted the square_raw_crop branch August 27, 2024 19:36
@kofa73
Copy link
Contributor

kofa73 commented Aug 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crop issues
3 participants