Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some OpenCL simplifications #17385

Merged

Conversation

jenshannoschwalm
Copy link
Collaborator

  1. kernel interpolate_bilinear does not require ch as a parameeter as it works fine with 1-4 channels. callers can be simplified.

  2. make some more use of dt_opencl_duplicate_image()

1. kernel interpolate_bilinear does not require ch as a parameeter
   as it works fine with 1-4 channels.
   callers can be simplified.

2. make some more use of dt_opencl_duplicate_image()
@jenshannoschwalm jenshannoschwalm added scope: codebase making darktable source code easier to manage OpenCL Related to darktable OpenCL code labels Aug 28, 2024
@jenshannoschwalm jenshannoschwalm added this to the 5.0 milestone Aug 28, 2024
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@TurboGit TurboGit merged commit 5db19d4 into darktable-org:master Aug 28, 2024
6 checks passed
@jenshannoschwalm jenshannoschwalm deleted the opencl_simplifications branch August 28, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenCL Related to darktable OpenCL code scope: codebase making darktable source code easier to manage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants