Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-native opencl pow function #17386

Closed

Conversation

jenshannoschwalm
Copy link
Collaborator

For integration test checks

For integration test checks
@jenshannoschwalm jenshannoschwalm marked this pull request as draft August 28, 2024 05:47
@jenshannoschwalm
Copy link
Collaborator Author

@TurboGit we might try this to rule out native_powr() imprecisions

@TurboGit
Copy link
Member

No change:

$ ./run.sh --op colorequal
Test 0158-coloreq-no-guided-filter
      Image mire1.cr2
      CPU & GPU version differ by 997354 pixels
      CPU vs. GPU report :
      ----------------------------------
      Max dE                   : 6.98332
      Avg dE                   : 0.21766
      Std dE                   : 0.37146
      ----------------------------------
      Pixels below avg + 0 std : 64.63 %
      Pixels below avg + 1 std : 87.49 %
      Pixels below avg + 3 std : 98.48 %
      Pixels below avg + 6 std : 99.74 %
      Pixels below avg + 9 std : 99.93 %
      ----------------------------------
      Pixels above tolerance   : 0.31 %
 
      Expected CPU vs. current CPU report :
      ----------------------------------
      Max dE                   : 1.37983
      Avg dE                   : 0.00848
      Std dE                   : 0.06640
      ----------------------------------
      Pixels below avg + 0 std : 98.05 %
      Pixels below avg + 1 std : 98.08 %
      Pixels below avg + 3 std : 98.19 %
      Pixels below avg + 6 std : 99.02 %
      Pixels below avg + 9 std : 99.69 %
      ----------------------------------
      Pixels above tolerance   : 0.00 %
 
  OK

Test 0159-coloreq-guided-filter
      Image mire1.cr2
      CPU & GPU version differ by 2.73934e+06 pixels
      CPU vs. GPU report :
      ----------------------------------
      Max dE                   : 12.86431
      Avg dE                   : 1.18455
      Std dE                   : 0.90806
      ----------------------------------
      Pixels below avg + 0 std : 67.59 %
      Pixels below avg + 1 std : 88.97 %
      Pixels below avg + 3 std : 97.73 %
      Pixels below avg + 6 std : 99.80 %
      Pixels below avg + 9 std : 99.98 %
      ----------------------------------
      Pixels above tolerance   : 9.09 %
 
      Expected CPU vs. current CPU report :
      ----------------------------------
      Max dE                   : 0.93404
      Avg dE                   : 0.00004
      Std dE                   : 0.00455
      ----------------------------------
      Pixels below avg + 0 std : 99.99 %
      Pixels below avg + 1 std : 99.99 %
      Pixels below avg + 3 std : 99.99 %
      Pixels below avg + 6 std : 99.99 %
      Pixels below avg + 9 std : 99.99 %
      ----------------------------------
      Pixels above tolerance   : 0.00 %
 
  OK

Total test 2

@jenshannoschwalm
Copy link
Collaborator Author

I modified the code for testing to do NO correction in the module, the problem is somewhere in the basic color space conversions it seems ...

@jenshannoschwalm jenshannoschwalm deleted the native_opencl branch August 30, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants