Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chore): Wrong panic in singleflight #436

Merged
merged 2 commits into from
Jan 11, 2024
Merged

fix(chore): Wrong panic in singleflight #436

merged 2 commits into from
Jan 11, 2024

Conversation

vejipe
Copy link
Collaborator

@vejipe vejipe commented Jan 9, 2024 •
edited
Loading

Proposal for a fix for the incorrect panic with singleflight.panicError when http.ErrAbortHandler in expected by net/http (see here) and http2 (see here).

References:

  • http.ErrAbortHandler panic is triggered by Caddy here.

@vejipe vejipe marked this pull request as draft January 9, 2024 14:38
@darkweak darkweak force-pushed the fix/chore/singleflight/wrong-panic branch from 9299416 to 628c234 Compare January 10, 2024 09:18
@vejipe vejipe marked this pull request as ready for review January 10, 2024 10:54
@darkweak darkweak merged commit 4700b6d into master Jan 11, 2024
20 checks passed
@darkweak darkweak deleted the fix/chore/singleflight/wrong-panic branch January 11, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vejipe @darkweak