Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Unused Code #9

Merged
merged 1 commit into from
May 29, 2021
Merged

Conversation

TheBrokenRail
Copy link

@TheBrokenRail TheBrokenRail commented May 11, 2020

This removed unused code, remove old XCode stuff, and add CMake files for the examples (that are not used by default).

Requires darlinghq/darling#778

@bugaevc
Copy link
Member

bugaevc commented May 11, 2020

Pretty sure we need at least NSPlatform (with subclasses). Please verify Foundation builds 🙂

@TheBrokenRail
Copy link
Author

I made a PR to turn the symlinks into regular files in Foundation, darlinghq/darling-foundation#8

I am going to try to build it now.

@TheBrokenRail
Copy link
Author

It builds!

@TheBrokenRail
Copy link
Author

Any Updates?

@TheBrokenRail
Copy link
Author

Rebased!

@TheBrokenRail
Copy link
Author

Any updates? I did confirm earlier that it does build.

@TheBrokenRail
Copy link
Author

Rebased! Any updates?

@ahyattdev
Copy link
Member

This is looking OK to me

@bugaevc
Copy link
Member

bugaevc commented Feb 12, 2021

I guess if we ever need to use any of those files, we can just bring them back?

@TheBrokenRail
Copy link
Author

I guess if we ever need to use any of those files, we can just bring them back?

Yeah, if we ever need these files, just use Git.

@TheBrokenRail
Copy link
Author

I re-based my PR and it builds now.

Instructions:

git clone https://github.com/TheBrokenRail/darling.git -b patch-32
cd darling
git remote set-url origin https://github.com/darlinghq/darling.git # Fix Broken Submodules
git submodule update --init --recursive
rm -rf src/external/cocotron/
git clone https://github.com/TheBrokenRail/darling-cocotron.git -b remove-unused-code src/external/cocotron
rm -rf src/external/foundation/
git clone https://github.com/TheBrokenRail/darling-foundation.git -b move-cocotron src/external/foundation

Copy link
Member

@facekapow facekapow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; tested and working.

@facekapow
Copy link
Member

I'm going to merge this in because, as Sergey noted above, we can just bring back the files if we ever need them.

@facekapow facekapow merged commit bfef2fd into darlinghq:master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants