Basic maintenance #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
force-pushed
the
2407_update_and_fixes
branch
3 times, most recently
from
a1fd4cf
to
ca43263
Compare
There is no need to be remotely fetching code for a simple 100 lines file of code which should never change anymore.
We use the first method from the documentation at https://packaging.python.org/en/latest/guides/single-sourcing-package-version. Thanks to Weiliang Li (Github: https://github.com/kigawas) for pointing out the source build was broken and proposing a (different) fix.
darosior
force-pushed
the
2407_update_and_fixes
branch
3 times, most recently
from
37a7fda
to
bbf0c94
Compare
darosior
added a commit
that referenced
this pull request
Jul 22, 2024
darosior
force-pushed
the
2407_update_and_fixes
branch
2 times, most recently
from
0820085
to
888ed32
Compare
|
Sigh... Now the MacOS build seems to randomly fail sometimes. |
darosior
force-pushed
the
2407_update_and_fixes
branch
3 times, most recently
from
8b91fff
to
01ae0a8
Compare
darosior
force-pushed
the
2407_update_and_fixes
branch
4 times, most recently
from
4695bf6
to
cf6abd5
Compare
Install python-bip32 from source to avoid #41 from happening again. Unfortunately building coincurve on MacOS keeps failing for esoteric reasons and i don't have infinite time, so on MacOS first install coincurve wheels before installing python-bip32.
darosior
force-pushed
the
2407_update_and_fixes
branch
from
cf6abd5
to
a1cb75a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updates (don't need base58 as a dependency) and some fixes (for the ci and for the issue reported in #41).