Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to associate Models to a cart item. #183

Merged
merged 9 commits into from
Jan 8, 2020

Conversation

alhaji-aki
Copy link
Contributor

Fixes #92 Well I was able to do something regarding this issue. I hope it is accepted. Please this is my first ever pull request so I pray it works and is accepted. Thanks for this package.

Copy link
Owner

@darryldecode darryldecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you as well update the docs(readme)? I am still reviewing this PR. Thanks for your effort.

@alhaji-aki
Copy link
Contributor Author

can you as well update the docs(readme)? I am still reviewing this PR. Thanks for your effort.

I did check here Associating Models

Copy link
Contributor Author

@alhaji-aki alhaji-aki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read me docs has already been updated

@darryldecode
Copy link
Owner

Hi @alhaji-aki sorry for late review, very busy :( I finally had the time. If you have some spare time, can you check the 1 failing test before I merge. I already resolved the conflicts. Thanks!

image

@alhaji-aki
Copy link
Contributor Author

Ok will do so... later in the day...

@darryldecode
Copy link
Owner

@alhaji-aki thank you 👍

@darryldecode darryldecode merged commit 93ddfa9 into darryldecode:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to associate a product model to an item
2 participants