Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing share to singleton #82

Merged
merged 3 commits into from
Mar 8, 2017
Merged

Changing share to singleton #82

merged 3 commits into from
Mar 8, 2017

Conversation

frezno
Copy link
Contributor

@frezno frezno commented Feb 5, 2017

With Laravel 5.4 the share method has been deprecated so we have to change it using the singleton method.

With Laravel 5.4 the share method has been deprecated and we have to use the singleton method.
Changing share to singleton
@odinns
Copy link

odinns commented Feb 13, 2017

I tried to apply this pull request as a patch (using https://github.com/cweagans/composer-patches), and then upgrading Laravel to 5.4, but one more change is needed - that the composer.json require section is updated for 5.4.

Probably this will do:

    "require": {
        "php": ">=5.4.0",
        "illuminate/support": "5.0.*|5.1.*|5.2.*|5.3.*|5.4.*",
        "illuminate/validation": "5.0.*|5.1.*|5.2.*|5.3.*|5.4.*",
        "illuminate/translation": "5.0.*|5.1.*|5.2.*|5.3.*|5.4.*"
    },

However this will not take effect as a patch, so I hope that this will be merged soon :-)

@frezno
Copy link
Contributor Author

frezno commented Feb 13, 2017

you can add my fork as repository to your composer.json file to make it work.
After adding it, run composer update and the pull requests will be added as well:

excerpt of the modified composer.json:
`

"type": "project",
"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/frezno/laravelshoppingcart"
    }
],
"require": {
    "php": ">=5.6.4",
    "laravel/framework": "5.4.*",
    "laravel/tinker": "~1.0",
    "darryldecode/cart": "dev-master"
},

`

@branchzero
Copy link

@darryldecode Could you have a time to review it and get it merged. So the package can be used in laravel 5.4. Thank you :)

@frezno
Copy link
Contributor Author

frezno commented Mar 8, 2017

@branchzero you can use my fix as shown above or you can use my fork of this cart as shown here:
https://github.com/frezno/freznocart
I didn't change anything in this fork but make it Laravel 5.4 compatibel.

@branchzero
Copy link

@frezno Okay,I will have a try, thank you!

@darryldecode darryldecode merged commit a8063ee into darryldecode:master Mar 8, 2017
@darryldecode
Copy link
Owner

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants