Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Add extra flags to disable throttling behavior. #55

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Add extra flags to disable throttling behavior. #55

merged 2 commits into from
Feb 16, 2024

Conversation

sigmundch
Copy link
Contributor

Add extra flags to disable throttling behavior.

These flags were added in our internal SDK test infrastructure and they
helped reduce flaky timeout behavior in the past. It's very likely that
these and the --disable-background-timer-throttling flag that's
already here have some overlap, though.

I have not been able to find much documentation about whether they do
overlap, so I was inclined to try to add these by default and
assess the effect in our CI.

Thoughts?

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@sigmundch
Add extra flags to disabling throttling behavior.
29ba399 
These flags [were added in our internal SDK test infrastructure][1] and they
helped reduce flaky timeout behavior in the past. It's very likely that
these and the `--disable-background-timer-throttling` flag that's
already here have some overlap, though.

I have not been able to find much documentation about whether they do
overlap, so I was inclined to try to add these by default and
assess the effect in our CI.

[1]: https://dart-review.googlesource.com/c/sdk/+/325780/2/pkg/test_runner/lib/src/browser_controller.dart
@sigmundch
... add CHANGELOG
d4caef8
@sigmundch sigmundch requested a review from devoncarew February 16, 2024 21:12
@sigmundch
Copy link
Contributor Author

cc @whesse - since you initially added these flags internally. Do you know if they do the same thing as --disable-background-timer-throttling? Maybe the blink flag does, but the other one doesn't?

devoncarew
devoncarew approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm for the flags

cc @natebosch just for fyi; I remember him spending time debugging flakey tests in chrome

@sigmundch sigmundch merged commit 7956230 into master Feb 16, 2024
3 checks passed
@sigmundch sigmundch deleted the chrome_flags branch February 16, 2024 22:32
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Feb 21, 2024
@devoncarew
[deps] rev async, browser_launcher, dartdoc, http, markdown, protobuf…
7c223d8 
…, sse, stream_channel, tools, vector_math, web, webdev, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/24266ca..6cdbc41):
  6cdbc41  2024-02-15  Kevin Moore  Update to latest lints, require Dart 3.2 (dart-archive/async#267)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/74a0efe..7956230):
  7956230  2024-02-16  sigmundch  Add extra flags to disable throttling behavior. (dart-archive/browser_launcher#55)

dartdoc (https://github.com/dart-lang/dartdoc/compare/7e171fc..7a9df65):
  7a9df65f  2024-02-20  Parker Lougheed  Add fallback text for sidebar failing to load (dart-lang/dartdoc#3643)
  9bcabb50  2024-02-20  Parker Lougheed  Fix missing left sidebar on extension type pages (dart-lang/dartdoc#3662)
  e8b8faa2  2024-02-16  Sam Rawlins  Include extension types in 'implementers' list (dart-lang/dartdoc#3658)

http (https://github.com/dart-lang/http/compare/6d9f9ef..ce0de37):
  ce0de37  2024-02-21  Derek Xu  Populate package:http_profile (dart-lang/http#1046)
  75e01f4  2024-02-20  Brian Quinlan  Create a simple WebSocket interface (dart-lang/http#1128)

markdown (https://github.com/dart-lang/markdown/compare/c2b8429..d735b0b):
  d735b0b  2024-02-21  Tom Yeh  Fix `#578`: list with checkbox mixed with empty lines (dart-lang/markdown#583)
  6efe141  2024-02-14  Kevin Moore  Migrate example to pkg:web, update minimum required Dart version (dart-lang/markdown#582)

protobuf (https://github.com/dart-lang/protobuf/compare/a293fb9..f085bfd):
  f085bfd  2024-02-20  Ömer Sinan Ağacan  Fix message_set.dart copyright year (google/protobuf.dart#912)

sse (https://github.com/dart-lang/sse/compare/af7d8d0..13ec752):
  13ec752  2024-02-20  Kevin Moore  blast_repo fixes (dart-lang/sse#104)
  2830dc9  2024-02-16  Kevin Moore  Support the latest pkg:web, require Dart 3.3 (dart-lang/sse#103)

stream_channel (https://github.com/dart-lang/stream_channel/compare/851336f..e02a5dd):
  e02a5dd  2024-02-16  Kevin Moore  Require Dart 3.3, update and fix lints (dart-lang/stream_channel#100)
  e62706e  2024-02-16  Kevin Moore  blast_repo fixes (dart-lang/stream_channel#101)

tools (https://github.com/dart-lang/tools/compare/2ef7673..9f4e6a4):
  9f4e6a4  2024-02-16  Elias Yishak  Helper to resolve dart version for clients of analytics (dart-lang/tools#233)
  8323b21  2024-02-13  Elias Yishak  New event added for sending analytics within package on errors (dart-lang/tools#229)

vector_math (https://github.com/google/vector_math.dart/compare/cb976c7..3706feb):
  3706feb  2024-02-18  dependabot[bot]  Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (google/vector_math.dart#313)

web (https://github.com/dart-lang/web/compare/a54a1f0..975e55c):
  975e55c  2024-02-15  Kevin Moore  Add TrustedTypes (dart-lang/web#173)
  0447807  2024-02-15  Srujan Gaddam  Add info on generation conventions (dart-lang/web#171)

webdev (https://github.com/dart-lang/webdev/compare/629c632..51b5484):
  51b54843  2024-02-14  Elliott Brooks  Implement `setFlag` for 'pause_isolates_on_start' (dart-lang/webdev#2373)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/2a9a11b..82ab64d):
  82ab64d  2024-02-21  Danny Tuppeny  Fix line endings for inserted maps on Windows (dart-lang/yaml_edit#66)
  6906ac4  2024-02-20  Devon Carew  update the publish workflow (dart-lang/yaml_edit#67)

Change-Id: I246c393586e3d6239925ac3cf3a6a245d86a2bf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353581
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
mosuem pushed a commit to dart-lang/tools that referenced this pull request Oct 25, 2024
@sigmundch
Add extra flags to disable throttling behavior. (dart-archive/browser…
ee14d22 
…_launcher#55)

* Add extra flags to disabling throttling behavior.

These flags [were added in our internal SDK test infrastructure][1] and they
helped reduce flaky timeout behavior in the past. It's very likely that
these and the `--disable-background-timer-throttling` flag that's
already here have some overlap, though.

I have not been able to find much documentation about whether they do
overlap, so I was inclined to try to add these by default and
assess the effect in our CI.

[1]: https://dart-review.googlesource.com/c/sdk/+/325780/2/pkg/test_runner/lib/src/browser_controller.dart

* ... add CHANGELOG
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devoncarew devoncarew devoncarew approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigmundch @devoncarew