Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Updates for Dart 2.0 core library changes (wave 2.2) #6

Merged
merged 2 commits into from
Feb 1, 2018
Merged

Updates for Dart 2.0 core library changes (wave 2.2) #6

merged 2 commits into from
Feb 1, 2018

Conversation

leafpetersen
Copy link
Contributor

Change classes that implement StreamTransformer to extend StreamTransformerBase.

@leafpetersen leafpetersen requested a review from kevmoo January 31, 2018 20:44
@keertip keertip mentioned this pull request Jan 31, 2018
Closed
43 tasks
kevmoo
kevmoo approved these changes Feb 1, 2018
View reviewed changes
Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No travis support, which is sad.

Did you verify the tests?

CHANGELOG.md Outdated
2.2). See [issue 31847][sdk#31847] for details.

[sdk#31847]: https://github.com/dart-lang/sdk/issues/31847

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra lines here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@leafpetersen
Copy link
Contributor Author

tests pass locally.

@leafpetersen leafpetersen merged commit 2ef12fd into master Feb 1, 2018
@leafpetersen leafpetersen deleted the corelib_2_2 branch February 1, 2018 16:33
@leafpetersen
Copy link
Contributor Author

@kevmoo will handle publishing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevmoo kevmoo kevmoo approved these changes

Assignees
No one assigned
Labels
cla: yes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leafpetersen @kevmoo @googlebot