This repository has been archived by the owner on Jul 16, 2023. It is now read-only.
fix: prefer conditional expressions rule #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… decrement operators
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 85.68% 85.71% +0.02%
==========================================
Files 226 226
Lines 4682 4689 +7
==========================================
+ Hits 4012 4019 +7
Misses 670 670
Continue to review full report at Codecov.
|
dkrutskikh
approved these changes
Nov 25, 2021
…nal_expressions # Conflicts: # CHANGELOG.md
incendial
reviewed
Nov 25, 2021
...nalyzers/lint_analyzer/rules/rules_list/prefer_conditional_expressions/examples/example.dart
Outdated
Show resolved
Hide resolved
...nalyzers/lint_analyzer/rules/rules_list/prefer_conditional_expressions/examples/example.dart
Outdated
Show resolved
Hide resolved
added 2 commits
November 25, 2021 20:50
incendial
approved these changes
Nov 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[X] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
#441
What changes did you make? (Give an overview)
Add checking for increment / decrement operations
Is there anything you'd like reviewers to focus on?
_isIncrementDecrementOperation() function in prefer_conditional_expressions_rule.dart