-
Notifications
You must be signed in to change notification settings - Fork 265
Conversation
Dart Code Metrics analyze report of dart_code_metrics. ✅Summary
|
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
==========================================
- Coverage 86.15% 86.04% -0.12%
==========================================
Files 234 235 +1
Lines 5013 5029 +16
==========================================
+ Hits 4319 4327 +8
- Misses 694 702 +8
Continue to review full report at Codecov.
|
output | ||
..writeln('') | ||
..writeln( | ||
'${alarmPen('✖')} total unused files - ${alarmPen(sortedRecords.length)}', | ||
'${alarmPen('✖')} total unused files - ${alarmPen(sortedRecords.length)}$removeFilesSuffix', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@incendial if we remove all unused files, why we in alarm state? I think this is good or info state, our repo not contains unused files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -95,6 +96,14 @@ class UnusedFilesAnalyzer { | |||
}).toSet(); | |||
} | |||
|
|||
Future<void> deleteAllUnusedFiles( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@incendial why this is async function? I see only sync methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Dart Code Metrics unused files report of dart_code_metrics. ✅Summary
|
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain: add a new flag to automatically delete unused files