Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

fix: correctly handle method invocations on getters #642

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

@incendial incendial added this to the 4.10.0 milestone Jan 12, 2022
@incendial incendial self-assigned this Jan 12, 2022
@github-actions
Copy link

github-actions bot commented Jan 12, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Jan 12, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 357

  • Total lines of source code: 6380

  • Total classes: 240

  • Average Cyclomatic Number per line of code: 0.35 / 1

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1034.0 hours

  • Found issues: 6 ⚠

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #642 (288d249) into master (c6d909a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
+ Coverage   86.10%   86.11%   +0.01%     
==========================================
  Files         235      235              
  Lines        5037     5043       +6     
==========================================
+ Hits         4337     4343       +6     
  Misses        700      700              
Impacted Files Coverage Δ
...zers/unused_l10n_analyzer/unused_l10n_visitor.dart 98.76% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d909a...288d249. Read the comment docs.

@dkrutskikh dkrutskikh merged commit 62e5602 into master Jan 12, 2022
@dkrutskikh dkrutskikh deleted the fix-unused-l10n branch January 12, 2022 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants