Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Added source argument when throwing a ArgParserException. #285

Closed
wants to merge 4 commits into from

Conversation

fa0311
Copy link
Contributor

@fa0311 fa0311 commented Sep 25, 2024

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@fa0311 fa0311 changed the title Added source argument when throwing a ArgParserException. Added source argument when throwing a ArgParserException. Sep 25, 2024
@jakemac53
Copy link
Contributor

I don't think I love the user facing result of this PR, which is that the default exception message ends up with an (at offset <index>) in the description. Lets just go with the original :).

@fa0311 fa0311 marked this pull request as ready for review October 2, 2024 00:37
Signed-off-by: ふぁ <yuki@yuki0311.com>
Signed-off-by: ふぁ <yuki@yuki0311.com>
Signed-off-by: ふぁ <yuki@yuki0311.com>
@mosuem
Copy link
Member

mosuem commented Oct 14, 2024

Closing as the dart-lang/args repository is merged into the dart-lang/core monorepo. Please re-open this PR there!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants