Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should give a nice error if using the flutter sdk with build_web_compilers #1946

Closed
jakemac53 opened this issue Jan 3, 2019 · 3 comments
Closed

We should give a nice error if using the flutter sdk with build_web_compilers #1946

jakemac53 opened this issue Jan 3, 2019 · 3 comments
Labels
package:build_web_compilers type-enhancement A request for a change that isn't a bug

Comments

@jakemac53
Copy link
Contributor

jakemac53 commented Jan 3, 2019 •
edited
Loading

Today if you are using the flutter sdk and try to run a web app with build_web_compilers it will fail with some very noisy and not very helpful errors (because ddc/dart2js don't ship with it).

We should try to recognize this situation and give a nice error.
@jakemac53 jakemac53 added package:build_web_compilers type-enhancement A request for a change that isn't a bug labels Jan 3, 2019
@natebosch
Copy link
Member

Maybe we should revisit the environment checks idea?

#961

@jakemac53
Copy link
Contributor Author

Yep that would probably be the cleanest way of resolving it

@jakemac53 jakemac53 mentioned this issue Jan 23, 2019
Closed
@jakemac53
Copy link
Contributor Author

ddc/dart2js do ship with the flutter sdk now, I think this should actually work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:build_web_compilers type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakemac53 @natebosch