-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow builder authors to define custom "environment checks" #961
Comments
I really like this idea, sort of a "doctor"-plugin. |
Bonus points if we can use the generic hooks to set up things for |
Imo anything opting into this should be able to return a success/failure state in some form as well so we don't attempt a build if things aren't set up properly. Not sure if we would need a way of overriding that check or not. |
Also we talked offline but this should run in a separate isolate so that builders can't do bad things - that allows us to expose information to them in this phase that wouldn't otherwise be accessible (such as the package graph), without worrying about breaking hermetic builds. |
We might also want to consider only running this with a special command |
I'd love to see it happen when the build script would change. |
These would run before a build (maybe not every time though?) and would give a hook to check on the user's environment and offer help.
Some examples:
built_value
could check thatbuilt_value_generator
is in the dependencies so that it's builder will run.$PATH
and either give a nice error message or offer to install the tools.We'd want these to be isolated from the rest of the build.
The text was updated successfully, but these errors were encountered: