Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LanguageFeature/Instantiate-to-bounds tests in pre-nnbd branch should be reviewed and updated. #1202

Closed
iarkh opened this issue Sep 23, 2021 · 2 comments
Closed

LanguageFeature/Instantiate-to-bounds tests in pre-nnbd branch should be reviewed and updated. #1202

iarkh opened this issue Sep 23, 2021 · 2 comments
Assignees
@iarkh

Comments

@iarkh
Copy link
Contributor

iarkh commented Sep 23, 2021

LanguageFeature/Instantiate-to-bounds tests in pre-nnbd branch differ from the master ones.
For some i-2-b cases, expected behavior of nnbd and pre-nnbd versions should be different.
So, these tests should be reviewed and triaged. Some changes made in master should be implemented in pre-nnbd.
@iarkh iarkh self-assigned this Sep 23, 2021
iarkh added a commit that referenced this issue Sep 28, 2021
@iarkh
Issue #1202: LanguageFeature/class tests updated: missing Issue tags …
cb46acf 
…added.
iarkh added a commit that referenced this issue Sep 28, 2021
@iarkh
Issue #1202: LanguageFeature/typedef/fynamic tests updated: missing I…
249a0ad 
…ssue tags added, needless dynamic tests removed.
iarkh added a commit that referenced this issue Oct 3, 2021
@iarkh
Issue #1202: LanguageFeature/typedef/static tests updated.
be447ea
iarkh added a commit that referenced this issue Oct 4, 2021
@iarkh
Issue #1202: i-2-b tests updated: Issue tags added, needless dynamic …
dfa064b 
…tests removed.
iarkh added a commit that referenced this issue Oct 4, 2021
@iarkh
Issue #1202: i-2-b typedef tests updated: Issue tags added, needless …
a93f848 
…dynamic tests removed.
@iarkh
Copy link
Contributor Author

iarkh commented Oct 5, 2021 •
edited
Loading

The following tests fails in runtime and should be excluded because of the Issue 46483 closed as won't fix:

  • Language/Generics/typedef_A08_t02
  • Language/Generics/typedef_A08_t03
  • Language/Generics/typedef_A08_t04
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l1_t03
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l1_t04
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l1_t05
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l1_t08
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l1_t09
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l1_t10
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t01
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t02
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t03
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t04
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t06
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t07
  • LanguageFeatures/Instantiate-to-ound/typedef/static/typedef_l2_01_t08
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t09
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t10
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t11
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t12
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t13
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t14
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t15
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t16
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t17
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t18
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t19
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_01_t20
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t01
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t03
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t06
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t07
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t08
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t09
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t10
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t11
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t14
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t5
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t16
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t17
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t18
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t19
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_02_t20
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t02
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t04
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t06
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t07
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t08
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t09
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t12
  • LanguageFeatures/Instantiate-to-ound/typedef/static/typedef_l2_03_t13
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t14
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t15
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t16
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t17
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t18
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t19
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_03_t20
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t01
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t02
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t03
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t04
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t06
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t07
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t08
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t09
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t10
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t11
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t12
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t13
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t14
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t15
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t16
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t17
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t18
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t19
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_04_t20
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t01
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t02
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t03
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t04
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t06
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t07
  • LanguageFeatures/Instantiate-to-ound/typedef/static/typedef_l2_05_t08
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t09
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t10
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t11
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t12
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t13
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t14
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t15
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t16
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t17
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t18
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t19
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_05_t20
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t01
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t02
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t03
  • LanguageFeatures/Instantiate-to-ound/typedef/static/typedef_l2_06_t06
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t07
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t08
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t09
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t10
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t11
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t12
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t13
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t14
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t15
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t16
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t17
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t18
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t19
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_l2_06_t20
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_typedef_l1_t03
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_typedef_l1_t07
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_typedef_l1_t09
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_typedef_l1_t11
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_typedef_l1_t13
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_typedef_l1_t15
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_typedef_l1_t17
  • LanguageFeatures/Instantiate-to-bound/typedef/static/typedef_typedef_l1_t19

Other failing tests were corrected.

@iarkh
Copy link
Contributor Author

iarkh commented Oct 5, 2021

CL for status files update: https://dart-review.googlesource.com/c/sdk/+/215541

@iarkh iarkh closed this as completed Oct 7, 2021
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 14, 2021
@athomas
[co19] Roll co19_2 to a93f8484f7265f0849692d3b1208323393733f8d
938e7ae 
2021-10-04 irina.arkhipets@gmail.com Issue dart-lang/co19#1202: i-2-b typedef tests updated: Issue tags added, needless dynamic tests removed.
2021-10-04 irina.arkhipets@gmail.com Issue dart-lang/co19#1202: i-2-b tests updated: Issue tags added, needless dynamic tests removed.
2021-10-03 irina.arkhipets@gmail.com Issue dart-lang/co19#1202: LanguageFeature/typedef/static tests updated.
2021-09-28 irina.arkhipets@gmail.com Issue dart-lang/co19#1202: LanguageFeature/typedef/fynamic tests updated: missing Issue tags added, needless dynamic tests removed.
2021-09-28 irina.arkhipets@gmail.com Issue dart-lang/co19#1202: LanguageFeature/class tests updated: missing Issue tags added.

Change-Id: I186bcd9721e39cb145b2518e156bb0ab862a1a95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215544
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
@athomas athomas mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iarkh iarkh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iarkh