Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable instantiated representation type #2167

Closed
johnniwinther opened this issue Aug 9, 2023 · 0 comments
Closed

Nullable instantiated representation type #2167

johnniwinther opened this issue Aug 9, 2023 · 0 comments
Assignees
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@johnniwinther
Copy link
Member

This test fails on [cfe] Implement subtyping for ExtensionType

co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A17_t01 CompileTimeError (expected Pass)

because the instantiated representation type V2<String?, int?> is String? and therefore not assignable to Object. Given the description of the test, the type should probably have been V2<String, int?>.

@sgrekhov sgrekhov self-assigned this Aug 9, 2023
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Aug 9, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 9, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Aug 16, 2023
2023-08-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2211. Fix roll failures (dart-lang/co19#2212)
2023-08-16 sgrekhov22@gmail.com dart-lang/co19#2142. Add more dynamic semantics and member invocation tests (dart-lang/co19#2210)
2023-08-15 sgrekhov22@gmail.com dart-lang/co19#2142. Delete obsolete Inline-classes tests (dart-lang/co19#2209)
2023-08-14 sgrekhov22@gmail.com dart-lang/co19#2207. Fix roll failures (dart-lang/co19#2208)
2023-08-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2195. Fix typos and a runtime error in static_analysis_member_invocation_A07_t01.dart (dart-lang/co19#2204)
2023-08-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2196. Expect additional error in syntax_A04_t01.dart (dart-lang/co19#2205)
2023-08-14 sgrekhov22@gmail.com dart-lang/co19#2142. Move and rename dynamic semantics extension type tests (dart-lang/co19#2206)
2023-08-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2190. Fix representation dependency in static_analysis_extension_types_A19_t01.dart (dart-lang/co19#2198)
2023-08-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2194. Fix typo in static_analysis_extension_types_A21_t06.dart (dart-lang/co19#2203)
2023-08-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2191. Fix typos in static_analysis_extension_types_A21_t01.dart (dart-lang/co19#2199)
2023-08-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2189. Fix typos in extension types tests (dart-lang/co19#2200)
2023-08-14 sgrekhov22@gmail.com Fixes dart-lang/co19#21892. Fix typo in static_analysis_extension_types_A21_t02.dart (dart-lang/co19#2201)
2023-08-14 sgrekhov22@gmail.com Fixes dart-lang/co19#21892. Fix typo in static_analysis_extension_types_A21_t05.dart (dart-lang/co19#2202)
2023-08-11 sgrekhov22@gmail.com Fixes dart-lang/co19#2172. Fix error expectations in static_analysis_extension_types_A02_t02.dart (dart-lang/co19#2180)
2023-08-11 sgrekhov22@gmail.com dart-lang/co19#2142. Change dynamic semantics inline class tests to be extension type tests (dart-lang/co19#2188)
2023-08-11 sgrekhov22@gmail.com dart-lang/co19#2142. Move static analysis member invocation tests to Extension types dir (dart-lang/co19#2187)
2023-08-11 sgrekhov22@gmail.com Fixes dart-lang/co19#2174. Add missing import (dart-lang/co19#2182)
2023-08-11 sgrekhov22@gmail.com dart-lang/co19#2142. Rename and move tests to Extension type dir (dart-lang/co19#2186)
2023-08-11 sgrekhov22@gmail.com Fixes dart-lang/co19#2175. Fix tests that check extension types implementing enumerated types (dart-lang/co19#2183)
2023-08-11 sgrekhov22@gmail.com Fixes dart-lang/co19#2176. Fix unintended error in static_analysis_extension_types_A11_t01.dart (dart-lang/co19#2184)
2023-08-11 sgrekhov22@gmail.com Fixes dart-lang/co19#2177. Fix typo in static_analysis_extension_types_A16_t05.dart (dart-lang/co19#2185)
2023-08-11 sgrekhov22@gmail.com Fixes dart-lang/co19#2173. Fix tests checking use of await for extension types (dart-lang/co19#2181)
2023-08-11 sgrekhov22@gmail.com Fixes dart-lang/co19#2171. Fix typos, adjust error expectations (dart-lang/co19#2179)
2023-08-10 sgrekhov22@gmail.com dart-lang/co19#2142. Change composing inline class tests to be extension type tests (dart-lang/co19#2170)
2023-08-10 sgrekhov22@gmail.com Fixes dart-lang/co19#2167. Fix typo in static_analysis_extension_types_A17_t01.dart (dart-lang/co19#2168)
2023-08-10 sgrekhov22@gmail.com Fixes dart-lang/co19#2139. Add generator functions element type tests (dart-lang/co19#2153)
2023-08-09 sgrekhov22@gmail.com dart-lang/co19#2142. Change static analysis member invocation tests to be extension type tests (dart-lang/co19#2150)
2023-08-08 sgrekhov22@gmail.com dart-lang/co19#2142. Add more static analysis of extension types tests (dart-lang/co19#2166)
2023-08-08 sgrekhov22@gmail.com dart-lang/co19#2142. Add more static analysis tests (dart-lang/co19#2165)

Change-Id: Ib1f0a9a1f2615b9f9783b1d7fa1b60c4d6c0389c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/321140
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Development

No branches or pull requests

2 participants