Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit call method tear-offs with extension typed receivers #2428

Closed
eernstg opened this issue Dec 13, 2023 · 2 comments
Closed

Implicit call method tear-offs with extension typed receivers #2428

eernstg opened this issue Dec 13, 2023 · 2 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug

Comments

@eernstg
Copy link
Member

eernstg commented Dec 13, 2023

The proposal in dart-lang/language#3467 was accepted by the language team. This means that it should be possible to perform .call method tear-offs also in the case where the receiver is an expression whose static type is an extension type. In this case it should be possible to tear off both a call method which is a non-extension type member (that is, inherited from some "normal" type), and also a call method which is an extension type member (from the receiver type or "inherited" from some other extension type).

@sgrekhov, I think no such tests have been written, isn't that true?

@eernstg
Copy link
Member Author

eernstg commented Dec 14, 2023

Thanks! dynamic_semantics_member_invocation_A03_t06.dart gets close because it uses the call of an extension type implicitly in line 45 and 47. But it's an invocation, and the new thing is that it can also be a tear-off.

sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 18, 2023
@eernstg eernstg closed this as completed in 155e055 Jan 9, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jan 12, 2024
2024-01-12 sgrekhov22@gmail.com Fixes dart-lang/co19#2480. Fix typos, add issue numbers (dart-lang/co19#2481)
2024-01-10 sgrekhov22@gmail.com dart-lang/co19#2477. Rename and reorder existing constants tests for match operators before adding new ones (dart-lang/co19#2478)
2024-01-10 sgrekhov22@gmail.com dart-lang/co19#2420. Add null-check-pattern tests for extension types (dart-lang/co19#2475)
2024-01-10 sgrekhov22@gmail.com dart-lang/co19#2119. Add missing experimental flags (dart-lang/co19#2474)
2024-01-10 sgrekhov22@gmail.com dart-lang/co19#2119. Fix typo and improve error messages in Timer tests (dart-lang/co19#2473)
2024-01-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2471. Fix timer constructor tests. Add check for microtasks (dart-lang/co19#2472)
2024-01-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2428. Add `call` member tests for extension types (dart-lang/co19#2438)
2024-01-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2449. Update positions of analyzer expected errors (dart-lang/co19#2450)
2024-01-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2440. Add asyncStart/End() to Stream interface tests (dart-lang/co19#2457)
2024-01-09 sgrekhov22@gmail.com dart-lang/co19#2420. Add another variable pattern exhaustiveness test (dart-lang/co19#2469)
2024-01-08 sgrekhov22@gmail.com dart-lang/co19#2420. Add constant pattern exhaustiveness tests (dart-lang/co19#2467)
2024-01-08 sgrekhov22@gmail.com dart-lang/co19#2436. Add expected constant evaluation error for CFE (dart-lang/co19#2470)
2024-01-08 sgrekhov22@gmail.com dart-lang/co19#2420. Add null-assert pattern exhaustiveness tests (dart-lang/co19#2468)
2024-01-05 sgrekhov22@gmail.com dart-lang/co19#2420. Add parenthesized pattern exhaustiveness tests (dart-lang/co19#2464)

Change-Id: I86862732cca7c042120bf312403279c2cc10c135
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345960
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants