#2420. Exhaustiveness variable tests. Add switch statement check #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Dec 29, 2023
There was a problem hiding this comment.
Blocked on dart-lang/language#3534.
Perhaps split this into one PR that uses return type String on a bunch of existing test functions containing switch expressions, and put the new tests into a different PR? We could then land the return-type part, and confine the blockedness to the second PR.
eernstg
added
the
status-blocked
sgrekhov
commented
Jan 24, 2024
sgrekhov
removed
the
status-blocked
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 26, 2024
2024-01-26 sgrekhov22@gmail.com dart-lang/co19#2485. Add constant evaluation tests for `Set` (dart-lang/co19#2509) 2024-01-26 sgrekhov22@gmail.com Fixes dart-lang/co19#2507. Fix roll failures (dart-lang/co19#2508) 2024-01-26 sgrekhov22@gmail.com dart-lang/co19#2485. Add is T constant evaluation tests (dart-lang/co19#2501) 2024-01-26 sgrekhov22@gmail.com dart-lang/co19#2485. Add `is! T` constant evaluation tests (dart-lang/co19#2504) 2024-01-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2503. Update exhaustiveness_map_A02_t02.dart according to the flow analysis change (dart-lang/co19#2503) 2024-01-25 sgrekhov22@gmail.com dart-lang/co19#2420. Exhaustiveness variable tests. Add switch statement check (dart-lang/co19#2453) 2024-01-22 sgrekhov22@gmail.com dart-lang/co19#2485. Add more constant evaluation tests for record types (dart-lang/co19#2499) 2024-01-22 sgrekhov22@gmail.com dart-lang/co19#2420. Add more exhaustiveness tests (dart-lang/co19#2498) Change-Id: If4af6cc1df4d44ad01e3578b8524748f67e7bac4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/348660 Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com>
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this pull request
Feb 15, 2024
…heck (dart-lang#2453) Exhaustiveness variable tests. Add switch statement check
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this pull request
Feb 15, 2024
…heck (dart-lang#2453) Exhaustiveness variable tests. Add switch statement check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.