Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2477. Add more constant evaluation tests #2484

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

sgrekhov
Copy link
Contributor

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of comments: We might want to have some cases that are slightly more complex, and perhaps the record tests don't contribute much.

@sgrekhov
Copy link
Contributor Author

Removed record types, added more complicated cases. Please take another look

@sgrekhov sgrekhov requested a review from eernstg January 16, 2024 12:22
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@eernstg eernstg merged commit a41f6ca into dart-lang:master Jan 17, 2024
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jan 19, 2024
2024-01-18 sgrekhov22@gmail.com dart-lang/co19#2477. Add test checking that an operator can be redeclared (dart-lang/co19#2495)
2024-01-18 sgrekhov22@gmail.com Fixes dart-lang/co19#2479. Delete outdated test co19/LibTest/ffi/sizeOf/sizeOf_A01_t02 (dart-lang/co19#2483)
2024-01-17 sgrekhov22@gmail.com dart-lang/co19#2485. Add constants `as T` tests (dart-lang/co19#2489)
2024-01-17 sgrekhov22@gmail.com dart-lang/co19#2477. Add more constant evaluation tests (dart-lang/co19#2484)
2024-01-17 sgrekhov22@gmail.com Fixes dart-lang/co19#2487. Add tests for type cast and type `void` (dart-lang/co19#2492)
2024-01-17 sgrekhov22@gmail.com Fixes dart-lang/co19#2486. `Pointer.elementAt` replaced by `+` operator (dart-lang/co19#2488)
2024-01-17 sgrekhov22@gmail.com Fixes dart-lang/co19#2491. Add test that an extension type cannot implement type `Never` (dart-lang/co19#2493)
2024-01-12 sgrekhov22@gmail.com dart-lang/co19#2477. Add match operators constants evaluation tests (dart-lang/co19#2482)

Change-Id: I1dee628d4685b0b24296aaabfcf4abcb659fa765
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/347240
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants