Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2522. Move type-normalization weak tests to TypeSystem dir #2526

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Feb 7, 2024

I checked *.status files there is no mentions of the old location of these weak tests. So, I believe it's safe to move them

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 329af71 into dart-lang:master Feb 7, 2024
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Feb 9, 2024
2024-02-08 sgrekhov22@gmail.com dart-lang/co19#2529. Remove tests with compile-time errors from core and html folders (dart-lang/co19#2530)
2024-02-08 sgrekhov22@gmail.com dart-lang/co19#2522. Move flow-analysis weak tests to TypeSystem dir (dart-lang/co19#2527)
2024-02-08 sgrekhov22@gmail.com Fix dart-lang/co19#2515. Remove strong-mode tests checking interaction with legacy (dart-lang/co19#2528)
2024-02-07 sgrekhov22@gmail.com dart-lang/co19#2522. Move type-normalization weak tests to TypeSystem dir (dart-lang/co19#2526)
2024-02-07 sgrekhov22@gmail.com dart-lang/co19#2522. Move subtyping tests to TypeSystem dir (dart-lang/co19#2525)
2024-02-07 sgrekhov22@gmail.com dart-lang/co19#2522. Move type-normalization tests to TypeSystem dir (dart-lang/co19#2524)
2024-02-06 sgrekhov22@gmail.com dart-lang/co19#2522. Move flow-analysis tests to TypeSystem dir (dart-lang/co19#2523)
2024-02-05 sgrekhov22@gmail.com Fix dart-lang/co19#2403. Add test for the new UP algorithm (dart-lang/co19#2520)
2024-02-05 sgrekhov22@gmail.com dart-lang/co19#2515. Fix const_evaluation_A10_t01.dart failure (dart-lang/co19#2519)

Change-Id: Ib6c00729b4a6aed3cb7ba2816eb46012ddef73a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350922
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants