Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2825. Add import inheritance and grammar tests #2843

Merged
merged 2 commits into from
Sep 3, 2024
Merged

#2825. Add import inheritance and grammar tests #2843

merged 2 commits into from
Sep 3, 2024

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Sep 3, 2024

No description provided.

eernstg
eernstg reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of part of directives must presumably be in a different location, and I'm suggesting a few extra test cases.

LanguageFeatures/Parts-with-imports/grammar_A01_t01_part1.dart Outdated Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/import_inheritance_A01_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/import_inheritance_A01_t01_part1.dart Outdated Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/import_inheritance_A01_t01_part2.dart Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/import_inheritance_A01_t02_part1.dart Outdated Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/import_inheritance_A01_t02_part2.dart Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/import_inheritance_A01_t01_part1.dart Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/import_inheritance_A01_t01_part2.dart Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/import_inheritance_A01_t01.dart Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/parts_lib.dart Show resolved Hide resolved
sgrekhov
sgrekhov commented Sep 3, 2024
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the very detailed review! Updated. PTAL

LanguageFeatures/Parts-with-imports/grammar_A01_t01_part1.dart Outdated Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/import_inheritance_A01_t01.dart Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/import_inheritance_A01_t01_part1.dart Outdated Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/import_inheritance_A01_t01_part2.dart Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/import_inheritance_A01_t02_part1.dart Outdated Show resolved Hide resolved
LanguageFeatures/Parts-with-imports/import_inheritance_A01_t02_part2.dart Show resolved Hide resolved
eernstg
eernstg approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eernstg eernstg merged commit 86b355a into dart-lang:master Sep 3, 2024
1 of 2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Sep 10, 2024
@sgrekhov
[co19] Roll co19 to a572236bc7d760dc986fd34abe6d0b8ae56254d7
ab23d7a 
2024-09-10 sgrekhov22@gmail.com Fixes dart-lang/co19#2852. Fix the new roll failures (dart-lang/co19#2853)
2024-09-09 sgrekhov22@gmail.com dart-lang/co19#2825. Add scope tests. Part 2. (dart-lang/co19#2847)
2024-09-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2849. Fix new roll failures (dart-lang/co19#2850)
2024-09-09 sgrekhov22@gmail.com dart-lang/co19#2559. Replace augmentation libraries by parts (dart-lang/co19#2848)
2024-09-05 sgrekhov22@gmail.com dart-lang/co19#2825. Add scope tests. Part 1. (dart-lang/co19#2845)
2024-09-04 sgrekhov22@gmail.com dart-lang/co19#2398. Update TouchEvent tests to not fail on platforms where it is not defined (dart-lang/co19#2844)
2024-09-03 sgrekhov22@gmail.com dart-lang/co19#2825. Add import inheritance and grammar tests (dart-lang/co19#2843)
2024-09-02 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting members tests. Part 2 (dart-lang/co19#2799)
2024-09-02 sgrekhov22@gmail.com dart-lang/co19#2825. Add enhanced parts tests for top-level declarations and ownership (dart-lang/co19#2842)
2024-09-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 4.2.1 to 4.2.2 in the github-actions group (dart-lang/co19#2841)
2024-08-30 sgrekhov22@gmail.com dart-lang/co19#2559. Add extension types to augmenting types tests (dart-lang/co19#2839)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: I26f83579708b877918b5a0a904f8172aa1cf4724
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384480
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgrekhov @eernstg