Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2976. Add more type inference tests #3004

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Dec 4, 2024

No description provided.

@sgrekhov sgrekhov marked this pull request as draft December 4, 2024 13:19
@sgrekhov
Copy link
Contributor Author

sgrekhov commented Dec 4, 2024

Sorry, it's not ready for the review yet. Converted to a draft.

@sgrekhov sgrekhov marked this pull request as ready for review December 4, 2024 15:51
@sgrekhov
Copy link
Contributor Author

sgrekhov commented Dec 4, 2024

Ready for review now.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of comments.

Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. PTAL.

@sgrekhov sgrekhov requested a review from eernstg December 5, 2024 08:27
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 2d1547e into dart-lang:master Dec 5, 2024
1 of 2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Dec 9, 2024
2024-12-06 sgrekhov22@gmail.com Fixes dart-lang/co19#3008. Rewrite type_inference_A01_t06.dart to get the context type _ (dart-lang/co19#3009)
2024-12-06 sgrekhov22@gmail.com Fixes dart-lang/co19#3006. Fix a typo in type_inference_A01_t06.dart (dart-lang/co19#3007)
2024-12-06 sgrekhov22@gmail.com dart-lang/co19#2976. Add type inference tests. Part 2 (dart-lang/co19#3005)
2024-12-05 sgrekhov22@gmail.com dart-lang/co19#2976. Add more type inference tests (dart-lang/co19#3004)
2024-12-04 sgrekhov22@gmail.com dart-lang/co19#2976. Add grammar, semantics and type inference test for constants (dart-lang/co19#3003)
2024-11-29 sgrekhov22@gmail.com dart-lang/co19#2976. Add more grammar, semantics and type inference test (dart-lang/co19#3002)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ie10a17900bc7d61d4f9288d3e3d2f359eca4f1d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399400
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants