-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2976. Add more grammar tests #3035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good!
I suggested a few changes to the terminology, just so we stick to known phrases where possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx! Updated. PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
2025-01-17 sgrekhov22@gmail.com Fixes dart-lang/co19#3044. Update expected errors positions for CFE (dart-lang/co19#3046) 2025-01-15 sgrekhov22@gmail.com dart-lang/co19#2976. Add more tests for records, factories and parenthesized expressions (dart-lang/co19#3047) 2025-01-15 sgrekhov22@gmail.com dart-lang/co19#2119. Actualize nnbd/static_errors_A12* description (dart-lang/co19#3048) 2025-01-14 sgrekhov22@gmail.com Fixes dart-lang/co19#3029. Add more tests for constants (dart-lang/co19#3045) 2025-01-14 sgrekhov22@gmail.com dart-lang/co19#2976. Add patterns tests (dart-lang/co19#3031) 2025-01-13 sgrekhov22@gmail.com dart-lang/co19#2976. Add more operators tests (dart-lang/co19#3043) 2025-01-13 sgrekhov22@gmail.com dart-lang/co19#3030. Add tests constants tests for String.length (dart-lang/co19#3041) 2025-01-13 sgrekhov22@gmail.com Fixes dart-lang/co19#3038. Read link to finalized object to avoid early finalization (dart-lang/co19#3042) 2025-01-10 sgrekhov22@gmail.com dart-lang/co19#2976. Add non-ambiguity tests (dart-lang/co19#3034) 2025-01-10 sgrekhov22@gmail.com dart-lang/co19#2976. Add more grammar tests (dart-lang/co19#3035) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I9feb50a33b33e85dc017d0d47829502d4f631ac7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405001 Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
No description provided.