#2976. Add more tests for nullable and FutureOr types #3050
Conversation
LanguageFeatures/Static-access-shorthand/constant_expression_A02_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A02_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A02_t02.dart
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A07_t01.dart
Outdated
Show resolved
Hide resolved
| /// also allows `int x = .tryParse(input) ?? 0;` to work, which it wouldn’t | ||
| /// otherwise because the context type of `.tryParse(input)` is `int?`. | ||
| /// | ||
| /// @description Checks that static access shorthand can be used with nullable |
There was a problem hiding this comment.
Typo
| /// @description Checks that static access shorthand can be used with nullable | |
| /// @description Checks that static access shorthands can be used with nullable |
There was a problem hiding this comment.
Replaced the entire description here and below.
| /// | ||
| /// It allows `int? v = .tryParse(42);` to work. That’s a pretty good reason. It | ||
| /// also allows `int x = .tryParse(input) ?? 0;` to work, which it wouldn’t | ||
| /// otherwise because the context type of `.tryParse(input)` is `int?`. |
There was a problem hiding this comment.
I don't think we'd otherwise have assertions from non-normative parts of a feature specification.
Also, it contradicts the normative parts of the feature specification (at this time, perhaps there was a time in the past where it didn't): The static namespace of T? is always the static namespace of T.
So maybe find a different location in the spec to provide the assertion?
There was a problem hiding this comment.
Moved to the type inference section. There are type_inference_A01_t01.dart and type_inference_A01_t02.dart that already check the similar functionality. But I prefer to leave them as tests that check that the correct type parameter is infered. Like C<int> c2 = .id<String>();.
So, I simply added these new tests checking nullable and FutureOr types for constructors (including factory ones) and static getters/methoods/variables.
| /// also allows `int x = .tryParse(input) ?? 0;` to work, which it wouldn’t | ||
| /// otherwise because the context type of `.tryParse(input)` is `int?`. | ||
| /// | ||
| /// @description Checks that static access shorthand can be used with nullable |
| /// also allows `int x = .tryParse(input) ?? 0;` to work, which it wouldn’t | ||
| /// otherwise because the context type of `.tryParse(input)` is `int?`. | ||
| /// | ||
| /// @description Checks that static access shorthand can be used with nullable |
| /// also allows `int x = .tryParse(input) ?? 0;` to work, which it wouldn’t | ||
| /// otherwise because the context type of `.tryParse(input)` is `int?`. | ||
| /// | ||
| /// @description Checks that static access shorthand can be used with nullable |
| /// also allows `int x = .tryParse(input) ?? 0;` to work, which it wouldn’t | ||
| /// otherwise because the context type of `.tryParse(input)` is `int?`. | ||
| /// | ||
| /// @description Checks that static access shorthand can be used with nullable |
LanguageFeatures/Static-access-shorthand/constant_expression_A02_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A02_t02.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A02_t02.dart
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/constant_expression_A07_t01.dart
Outdated
Show resolved
Hide resolved
| /// also allows `int x = .tryParse(input) ?? 0;` to work, which it wouldn’t | ||
| /// otherwise because the context type of `.tryParse(input)` is `int?`. | ||
| /// | ||
| /// @description Checks that static access shorthand can be used with nullable |
There was a problem hiding this comment.
Replaced the entire description here and below.
| FutureOr<C<int>?>? c5 = .staticMethod<int>(5); | ||
| Expect.equals(5, (await c5)?.value); | ||
|
|
||
| FutureOr<List<C<String>?>?>? c6 = .instances; |
There was a problem hiding this comment.
Thank you! Fixed in these tests. There are more tests containing this issue. I'll prepare a separate PR with will fix them.
| /// | ||
| /// It allows `int? v = .tryParse(42);` to work. That’s a pretty good reason. It | ||
| /// also allows `int x = .tryParse(input) ?? 0;` to work, which it wouldn’t | ||
| /// otherwise because the context type of `.tryParse(input)` is `int?`. |
There was a problem hiding this comment.
Moved to the type inference section. There are type_inference_A01_t01.dart and type_inference_A01_t02.dart that already check the similar functionality. But I prefer to leave them as tests that check that the correct type parameter is infered. Like C<int> c2 = .id<String>();.
So, I simply added these new tests checking nullable and FutureOr types for constructors (including factory ones) and static getters/methoods/variables.
sgrekhov
changed the title
No description provided.