Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option hideNegatable to ArgParser.flag() #132

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Oct 14, 2024

Recreating dart-archive/args#287


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem requested a review from sigurdm October 14, 2024 15:10
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
args Non-Breaking 2.6.1-wip 2.6.1-wip 2.6.1-wip ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage
pkgs/args/lib/src/allow_anything_parser.dart 💚 75 %
pkgs/args/lib/src/arg_parser.dart 💚 94 %
pkgs/args/lib/src/option.dart 💚 93 %
pkgs/args/lib/src/usage.dart 💚 99 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

pkgs/args/CHANGELOG.md Outdated Show resolved Hide resolved
@sigurdm
Copy link
Contributor

sigurdm commented Oct 21, 2024

Thanks for moving this!

@sigurdm sigurdm merged commit ba4b4af into main Oct 21, 2024
14 checks passed
@sigurdm sigurdm deleted the recreateSigurdsPR branch October 21, 2024 10:24
@mosuem
Copy link
Member Author

mosuem commented Oct 21, 2024

Thanks for moving this!

Well I also closed the original ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants