Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the codelabs branch into main branch #1823

Merged
merged 9 commits into from
Apr 20, 2021
Merged

Merge the codelabs branch into main branch #1823

merged 9 commits into from
Apr 20, 2021

Conversation

johnpryan
Copy link
Contributor

No description provided.

johnpryan added 3 commits April 6, 2021 10:35
@johnpryan
Codelab UI - initial setup (#1807)
89a4c47 
* initial setup

* setup YAML parsing

* format

* load codelab files

* move logic into CodelabUi class, start stubbing out code

* Set up right panels

* Add CodeMirror editor

* Add CodelabState

* fix HTML

* Add step buttons

* remove print

* Load code and update when the step changes

* Add run button and console panel

* add flutter_codelab

* Ignore /example/codelabs directory in analysis and builders

* Add tabs to console panel

* Get flutter compilation working

* add TODO

* exclude codelabs in dart_source_cleanup build step

* remove whitespace
@johnpryan
Add Github codelab fetcher (#1811)
8737b55 
* Add GithubCodelabFetcher

* make gh_ref and gh_path optional query parameters
@johnpryan
Add show solution button to Codelab UI (#1819)
dd51266 
* add codelabs.html to allowed files in main.py

* Add show solution button
@google-cla google-cla bot added the cla: yes label Apr 16, 2021
@johnpryan
Copy link
Contributor Author

FYI the only unreviewed commit is 4a90fa3, which runs dart format.

@johnpryan
Copy link
Contributor Author

@kevmoo should I commit the .g.dart files here? The build for b7a9f5b failed because I committed a .g.dart file:

  [SEVERE] Conflicting outputs were detected and the build is unable to prompt for permission to remove them. These outputs must be removed manually or the build can be run with `--delete-conflicting-outputs`. The outputs are: lib/codelabs/src/meta.g.dart

But 3353d19 fails because it does analysis before building the project. What's the best-practice here?

@kevmoo
Copy link
Member

kevmoo commented Apr 17, 2021

Should have --delete-conflicting-outputs in there.

@johnpryan
Copy link
Contributor Author

TBR: @domesticmouse @RedBrogdon

@johnpryan johnpryan merged commit bbefd4a into master Apr 20, 2021
domesticmouse
domesticmouse reviewed Apr 20, 2021
View reviewed changes
Copy link
Member

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing LGTM

@johnpryan johnpryan deleted the codelabs branch April 30, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domesticmouse domesticmouse domesticmouse left review comments

@RedBrogdon RedBrogdon Awaiting requested review from RedBrogdon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnpryan @kevmoo @domesticmouse