Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add highlighting to snippets diplayed in codelab instructions panel #1829

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Add highlighting to snippets diplayed in codelab instructions panel #1829

merged 2 commits into from
Apr 22, 2021

Conversation

johnpryan
Copy link
Contributor

Uses highlight.js with a custom theme to highlight.

Screen Shot 2021-04-21 at 10 09 47 AM

@johnpryan
Add highlighting to snippets diplayed in codelab instructions panel
913b44a 
Uses highlight.js with a custom theme to highlight.
@johnpryan johnpryan requested a review from domesticmouse April 21, 2021 17:10
@google-cla google-cla bot added the cla: yes label Apr 21, 2021
domesticmouse
domesticmouse approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to pull format check from beta and dev channel

RedBrogdon
RedBrogdon approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@RedBrogdon RedBrogdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a Dart package that could be used, rather than JS?

@johnpryan
Copy link
Contributor Author

I hadn't considered using Dart, there's highlight.dart. I might look into this if we have time

@johnpryan johnpryan merged commit 5ca651e into dart-lang:master Apr 22, 2021
This was referenced Apr 22, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedBrogdon RedBrogdon RedBrogdon approved these changes

@domesticmouse domesticmouse domesticmouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnpryan @domesticmouse @RedBrogdon