Format class declarations. #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For imports and exports, there is logic around how to split and format the "show" and "hide" combinators. I plan to use the same logic for "extends", "implements", and "with" clauses in classes so this generalizes that code to not be specific to imports. It's also a little simpler and cleaner now.
This handles all of the stuff that can appear outside of the braces in a class declaration: - The `class` keyword and any class modifiers. - The name. - Type parameters, if any. - The `extends`, `with`, and/or `implements` clauses. - The `native` clause. It doesn't handle members yet. It also handles ensuring there is a blank line before and after class declarations. In the process of doing that, I also migrated over similar code for function declarations where we ensure there is a blank line after non-empty functions.
# Conflicts: # lib/src/piece/clause.dart
natebosch
approved these changes
Nov 3, 2023
kallentu
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles all of the stuff that can appear outside of the braces in a class declaration:
classkeyword and any class modifiers.extends,with, and/orimplementsclauses.nativeclause.It doesn't handle members yet.
It also handles ensuring there is a blank line before and after class declarations. In the process of doing that, I also migrated over similar code for function declarations where we ensure there is a blank line after non-empty functions.