Better debug output for piece trees. #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old formatter has pretty nice debug output, but the new one is still
pretty rudimentary. This improves that situation somewhat from:
```
Sequence(Type(`class Foo` Block(`{` Sequence(Var(`static late final int` `i;`) Var(`static late int` `i;`) Var(`static late var` `i;`) Var(`covariant late var` `i;`) Var(`covariant late int` `i;`) Var(`late final int` `i;`) Var(`late int` `i;`) Var(`late var` `i;`)) `}`)))
```
To:
```
Seq(
Type(
`class Foo`
Block(
`{`
Seq(
Var(`static late final int` `i;`)
Var(`static late int` `i;`)
Var(`static late var` `i;`)
Var(`covariant late var` `i;`)
Var(`covariant late int` `i;`)
Var(`late final int` `i;`)
Var(`late int` `i;`)
Var(`late var` `i;`)
)
`}`
)
)
)
```
It also eliminates a bunch of pointless `toString()` implementations
that are only used for debugging and can be inferred from runtimeType.
natebosch
reviewed
Nov 16, 2023
natebosch
approved these changes
Nov 16, 2023
kallentu
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old formatter has pretty nice debug output, but the new one is still pretty rudimentary. This improves that situation somewhat from:
To:
It also eliminates a bunch of pointless
toString()implementations that are only used for debugging and can be inferred from runtimeType.