Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse with language version 3.3 #1330

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

parlough
Copy link
Member

Since extension types are now enabled by default (dart-lang/sdk@a19ae4e) and dart_style supports formatting extension types, the language version passed to the analyzer should be updated.

Reference: dart-lang/sdk#54139 (comment)

@munificent
Copy link
Member

Ah, yes, good catch! Would you mind also bumping the version number in the pubspec.yaml to 2.3.5-wip? That way we know this fix hasn't been released yet.

@parlough
Copy link
Member Author

Good point. Updated :)

Copy link
Member

@munificent munificent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! I'll merge this in and roll it into the SDK today.

@munificent munificent merged commit 8b1f24a into dart-lang:main Nov 29, 2023
7 checks passed
@parlough parlough deleted the fix/language-version-3-3 branch November 29, 2023 16:45
@babbage
Copy link

babbage commented Feb 27, 2024

It will be great when this update is released to production.

@munificent
Copy link
Member

munificent commented Mar 4, 2024

It's published to pub now. The 3.3 Dart SDK should already have the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants